Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): Hide 'no accounts' in collapsed sidebar #15714

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jvaclavik
Copy link
Contributor

Description

Related Issue

Resolve #15713

Screenshots:

before
image

after
image

@jvaclavik jvaclavik merged commit db404fa into develop Dec 3, 2024
22 checks passed
@jvaclavik jvaclavik deleted the fix-no-accounts-in-collapsed-sidebar branch December 3, 2024 10:51
@bosomt
Copy link
Contributor

bosomt commented Dec 4, 2024

QA NOK

i can still see it on develop after i disable coins to spawn no accounts text

Info:

  • Suite version: web 25.1.0 (b6003e8)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.5 regular (revision a61e783448043760a7c925e017bd08a4673a61c8)
  • Transport: BridgeTransport 2.0.33
Screen.Recording.2024-12-04.at.11.56.02.mov

@bosomt
Copy link
Contributor

bosomt commented Dec 11, 2024

not sure if not ok or not included in current RC @MiroslavProchazka

image

Info:

  • Suite version: desktop 24.12.1 (ec8321d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 17f2a3256b2631823c2bad1855fab61b27985fd2)
  • Transport: BridgeTransport 2.0.33

@MiroslavProchazka
Copy link
Contributor

It should be part of RC as it was merged before freeze.

@bosomt
Copy link
Contributor

bosomt commented Dec 17, 2024

QA NOK

image

Info:

  • Suite version: desktop 24.12.2 (40a2ae6)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.2 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 3.0.0-bundled.24.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Hide "no accounts" in collapsed sidebar
4 participants