Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ESLint and all plugis & revalidate the config and ALL of the rules #15267

Closed
wants to merge 29 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ed54d08
chore: add recommanded checks from eslint-plugin-jest
peter-sanderson Oct 31, 2024
a1c1dc3
chore: add 'import/no-duplicates' ESLint rule
peter-sanderson Oct 31, 2024
10ebe62
chore: remove ESLint so we can upgrade by installing fresh version
peter-sanderson Oct 30, 2024
e788ace
chore: re-introduce ESLint for the monorepo
peter-sanderson Oct 31, 2024
d66afbe
chore: fix code style
peter-sanderson Oct 31, 2024
668a7aa
fix: format
peter-sanderson Nov 1, 2024
096c3a3
chore: implement ESLint rulset as a package in the workspace
peter-sanderson Nov 1, 2024
7176b43
chore: re-add all our custom eslint rules
peter-sanderson Nov 4, 2024
db6e8e9
chore: add no-prototype-builtins ESLint rule as it became part of rec…
peter-sanderson Nov 4, 2024
31a6e8e
chore: progress
peter-sanderson Nov 4, 2024
d4d3fc5
fix: duplicate key
peter-sanderson Nov 4, 2024
0533c6c
fix: missing devDependency
peter-sanderson Nov 5, 2024
0019544
chore: more ESLint fixies
peter-sanderson Nov 5, 2024
c8aa119
chore: get rid of '@typescript-eslint/no-unused-vars': 'off', and enf…
peter-sanderson Nov 5, 2024
70da002
fix: wip
peter-sanderson Nov 5, 2024
b1456af
fix: local-rules/no-override-ds-component were not riggered correcly …
peter-sanderson Nov 5, 2024
8a23a79
chore: enable no-constant-binary-expression as it becames recommanded…
peter-sanderson Nov 5, 2024
fe888c1
chore: get rid of '@typescript-eslint/no-unused-vars': 'off', and enf…
peter-sanderson Nov 5, 2024
812fb29
chore: wip
peter-sanderson Nov 6, 2024
c162608
chore: enable no-extra-boolean-cast as it becames recomended
peter-sanderson Nov 6, 2024
82a9290
chore: wip
peter-sanderson Nov 6, 2024
7c73c09
chore: add no-async-promise-executor as it becames recommanded
peter-sanderson Nov 6, 2024
d1748b5
chore: enable import/order rule for whole codebase
peter-sanderson Nov 6, 2024
c4ab992
chore: enable import/order rule for whole codebase - manual fixies
peter-sanderson Nov 6, 2024
c56c7d7
chore: enable import/order rule for whole codebase - prettier fix
peter-sanderson Nov 6, 2024
0d37421
chore: remove all import/order offs
peter-sanderson Nov 6, 2024
2634229
chore: ignore some rules in packages
peter-sanderson Nov 6, 2024
74df31e
chore: no-control-regex as it becames recommanded
peter-sanderson Nov 6, 2024
b3a0ee3
chore: wip
peter-sanderson Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: format
peter-sanderson committed Nov 6, 2024
commit 668a7aa2d2737d9f6ae84e4a01f17c930c3a00b5
51 changes: 6 additions & 45 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -105,40 +105,10 @@ export default [
},
],
'@typescript-eslint/no-shadow': [
'error',
'off',
{
builtinGlobals: true,
allow: [
'_',
'error',
'resolve',
'reject',
'fetch',

// Todo: all below are magic, I have no idea why they are triggered
'Text',
'navigation',
'Screen',
'screen',
'top',
'Image',
'event',
'Event',
'alert',
'model',
'StyleSheet',
'Crypto',
'Keyboard',
'name',
'Clipboard',
'Storage',
'status',
'Notification',
'PermissionStatus',
'length',
'close',
'path',
],
builtinGlobals: false,
allow: ['_', 'error', 'resolve', 'reject', 'fetch'],
},
],
'@typescript-eslint/no-use-before-define': ['error'],
@@ -200,22 +170,13 @@ export default [
'jest/no-disabled-tests': 'off', // Well, what can I say... ¯\_(ツ)_/¯ We skip tests sometimes.
'jest/no-focused-tests': 'off', // Same as above, but // Todo: shall be easy to get rid of this
'jest/no-conditional-expect': 'off', // Todo: we shall solve this, this is bad practice
'jest/expect-expect': 'off', // Todo: we have test with no assertions, this may be legit but it needs to be checked
},
},
// {
// files: ['**/*.test.*', '**/__tests__/**/*'],
// rules: {
// 'import/no-extraneous-dependencies': 'off',
// 'import/no-unresolved': 'off',
// 'import/no-default-export': 'off',
// },
// },

// Suite Native E2E tests
{
files: ['suite-native/app/e2e/tests/**'],
files: ['**/__fixtures__/**/*'],
rules: {
'jest/expect-expect': 'off',
'import/no-default-export': 'off', // Todo: we have many default exports in fixtures, we shall get rid of them
},
},

Loading