Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: get rid of '@typescript-eslint/no-unused-vars': 'off', and enforce it everywhere #15221

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: get rid of '@typescript-eslint/no-unused-vars': 'off', and enforce it everywhere #15221

merged 1 commit into from
Nov 6, 2024

Conversation

peter-sanderson
Copy link
Contributor

No description provided.

@peter-sanderson peter-sanderson mentioned this pull request Nov 5, 2024
Closed
23 tasks
peter-sanderson
peter-sanderson commented Nov 5, 2024
View reviewed changes
packages/connect-explorer/src/pages/index.mdx
Card as TrezorCard,
CollapsibleBox,
variables,
Paragraph,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused Paragraph, I checked with fulltext search

Lemonexe
Lemonexe approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some of the occurrences of eslint-disable-next-line @typescript-eslint/no-unused-vars I really don't understand, but that's out of the scope of this PR to remove the dead code. It's legitimiate to just mark it and have codeowners solve it later 👍

@peter-sanderson peter-sanderson enabled auto-merge (rebase) November 6, 2024 18:17
@peter-sanderson peter-sanderson merged commit 1ad7b6f into develop Nov 6, 2024
31 checks passed
@peter-sanderson peter-sanderson deleted the no-unused-vars branch November 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemonexe Lemonexe Lemonexe approved these changes

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@komret komret Awaiting requested review from komret komret is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

@jvaclavik jvaclavik Awaiting requested review from jvaclavik

@seibei-iguchi seibei-iguchi Awaiting requested review from seibei-iguchi

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-sanderson @Lemonexe