fix(connect): skip fw hash check when binary too tiny (DX) #15201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
approved these changes
Nov 4, 2024
| @@ -773,8 +773,9 @@ export class Device extends TypedEmitter<DeviceEvents> { | |||
|
|
|||
| const btcOnly = this.firmwareType === FirmwareType.BitcoinOnly; | |||
| const binary = await getBinaryOptional({ baseUrl, btcOnly, release }); | |||
| if (binary === null) { | |||
| if (binary === null || binary.byteLength < 200) { | |||
There was a problem hiding this comment.
I would personally be more explicit, something like
if (binary.byteLenght < 200) {
log('skipping too small);
...
}
otherwise 👍
00ba609 to
9a0ce11
Compare
9a0ce11 to
f330e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When FW binary is only a git LFS pointer (which is the case on all web dev deployments), FW hash is mismatched so you get Ghost modal even with legit physical Trezor - example.
➡️ ignore the FW hash check for too small binary files
👀 You can verify on this dev deployment
ℹ️ This is DX only thing, won't happen in production