connect: initialize should be able to timeout #13227
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a heavy draft, to be discussed with @marekrjpolak first and szymonlesisz later
vide0.mov
I am able to reproduce this behavior through "uncooperative acquire". 1 instance of suite is doing discovery, another instance steals session. We should I am at fixing the root of the problem as well of course but on the other hand - some of the calls to the device should be timeout-able. This is something I would like to discuss with @marekrjpolak what is the right place to do this.
In the meantime I would probably add this little bandaid to fix a case where Suite stays hanged without any clear communication about what is happening.
There are possibly controversial commits:
After all the changes it looks like this:
vide1.mov
related