Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: initialize should be able to timeout #13227

Closed
wants to merge 2 commits into from

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Jul 8, 2024

This is a heavy draft, to be discussed with @marekrjpolak first and szymonlesisz later

  • it is possible to get the device into a state where it can't be worked with. It is enumerated but any attempts to open it or to write it will remain hanging forever. see video:
vide0.mov

I am able to reproduce this behavior through "uncooperative acquire". 1 instance of suite is doing discovery, another instance steals session. We should I am at fixing the root of the problem as well of course but on the other hand - some of the calls to the device should be timeout-able. This is something I would like to discuss with @marekrjpolak what is the right place to do this.

In the meantime I would probably add this little bandaid to fix a case where Suite stays hanged without any clear communication about what is happening.

There are possibly controversial commits:

  • 50191b4 - suite reducers did not accept change from unacquired to unreadable.
  • 717a857 - the band aid
  • e3446af - promises clearing to be discussed.

After all the changes it looks like this:

vide1.mov

related

@mroz22 mroz22 force-pushed the connect-timeout-initialize branch from cd83a17 to aa8fd75 Compare July 19, 2024 16:54
@mroz22 mroz22 closed this Dec 3, 2024
@mroz22 mroz22 deleted the connect-timeout-initialize branch December 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant