feat(suite): node bridge rollout only in EAP #13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45071b8 to
b62d33b
Compare
marekrjpolak
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's only allow node-bridge rollout for users who have EAP enabled. I am particularly concerned about #12163 and in general that we haven't yet tested it on a substantial number of machines.
Screenshots
even when your rollout score is below the threshold you get the old bridge because EAP is not active (screenshot is not the best I could get but there are few red pixels visible in the bottom left corner meaning that there are no violet pixels)
as it is now,
--skip-new-bridge-rolloutdoes not apply when EAP is off. not sure what should be stronger