Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite): fix copy in xpub modal #13217

Closed
wants to merge 1 commit into from
Closed

fix(suite): fix copy in xpub modal #13217

wants to merge 1 commit into from

Conversation

MiroslavProchazka
Copy link
Contributor

Resolves #12577

@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review July 5, 2024 18:52
@MiroslavProchazka MiroslavProchazka requested a review from komret as a code owner July 5, 2024 18:52
@MiroslavProchazka MiroslavProchazka force-pushed the xpub-modal-string-change branch from 445371f to 31cdc73 Compare July 6, 2024 07:38
@MiroslavProchazka MiroslavProchazka force-pushed the xpub-modal-string-change branch from 31cdc73 to a40905f Compare July 6, 2024 07:42
komret
komret requested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@komret komret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This breaks it for the receive flow.

@MiroslavProchazka MiroslavProchazka deleted the xpub-modal-string-change branch July 25, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-sanderson peter-sanderson peter-sanderson left review comments

@komret komret komret requested changes

@tomasklim tomasklim Awaiting requested review from tomasklim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy in XPUB modal
3 participants
@MiroslavProchazka @komret @peter-sanderson