Chore/native/use add coin returns error #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juriczech
reviewed
Jul 5, 2024
suite-native/module-add-accounts/src/components/AccountTypeDecisionBottomSheet.tsx
Show resolved
Hide resolved
juriczech
suggested changes
Jul 5, 2024
There was a problem hiding this comment.
This is not working as expected. First we need to refactor fetchBundleDescriptorsThunk and it's return value from connect. The thunk returns empty array if no bundle was found (if there was error). We need to change that so that it doesn't return empty array but an error. Than we propagate the error to the callers.
You've actually made matters worse a little bit since add coin on develop returns at least basic error, now it actually doesn't do anything and just hangs on a loading screen.
If you'd like, maybe we could huddle and I might explain better looking at the code.
31838cc to
fb5a9c3
Compare
|
/rebase |
79f1c26 to
2b8d54e
Compare
2b8d54e to
fe64724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #13163