Feat/native/feature requests passphrase #13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacadda to
1ab6262
Compare
matejkriz
reviewed
Jul 4, 2024
suite-native/module-authorize-device/src/usePassphraseAuthorizationSuccess.ts
Show resolved
Hide resolved
52b323e to
2dab07f
Compare
This was referenced Jul 9, 2024
Closed
matejkriz
requested changes
Jul 9, 2024
There was a problem hiding this comment.
FIXED
I spotted one bug:
- Discover standard wallet
- make it view-only
- open new passphrase
- make it view-only
- disconnect Trezor
- reconnect Trezor
- go to verify Receive address
- click red Cancel button in app (see screenshot)
Passphrase wallet is rejected completely and I'm navigated to dashboard of standard wallet. I would expect to go back to receive screen instead.
suite-native/module-authorize-device/src/screens/connect/ConnectingDeviceScreen.tsx
Show resolved
Hide resolved
suite-native/device-authorization/src/deviceAuthorizationSlice.ts
Outdated
Show resolved
Hide resolved
matejkriz
requested changes
Jul 9, 2024
There was a problem hiding this comment.
FIXED
And one inconsistency:
- If I click on 'X' while entering passhprase in app, it navigate somewhere else than the same button while entering passhprase on Trezor
Passhprase in app navigate back to top level (dashboard/My assets/Receive)
Passhprase on device just closing passphrase form and stay on Receive page
Fix here: 73fa108 |
I believe this should fix that. Could you please try to retest it? 🙏 |
matejkriz
reviewed
Jul 10, 2024
suite-native/device-authorization/src/hooks/useAuthorizationGoBack.ts
Outdated
Show resolved
Hide resolved
b58ba58 to
6a65d5b
Compare
feat(suite-native): create navigation handler
6a65d5b to
7cd6fb8
Compare
7cd6fb8 to
94f10c4
Compare
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables device communication during locked & remembered passphrase device. In that case, device doesn't allow communication until device is unlocked via pin + passphrase. With how the code looked previous to these changes, navigation and cancelling authorization flow was quite problematic.
Modules for passphrase and device connection were merged into one:
module-authorize-device. This was done so that these authorization screens are together within one stack so that we can go back to previous stack, without having to define it, once the flow is finished, be it success or fail.Commits:
TrezorConnect.on()listeners into a redux state logic as it's more flexible and allows for better cooperation with already existing pin logic, which was previously refactored into redux as wellmodule-passphraseintomodule-connect-deviceand merge stacks into oneisCreatingNewPassphraseWalletflag in redux state so it allows us to treat these flows differently - specifically for exiting themmodule-connect-devicetomodule-authorize-devicemodule-authorize-deviceto fit package name (separated commits for better code review readability)module-passphrasehas been removed, I also removed packagepassphrase. Without this, we would have circular dependencies in future, so the logic was moved todevice-authorizationpackage.Related Issue
Resolve #12132
Resolve #12689
Screenshots:
Zaznam.obrazovky.2024-07-04.v.12.48.20.mov
Error state visible here (copy and styles to be changed in a follow up PR):
Zaznam.obrazovky.2024-07-04.v.13.27.38.mov