Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native): passphrase loading has subtitle #13073

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Jun 25, 2024

Add subtitle to passphrase loading

Related Issue

Resolve #12719

Screenshots:

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-25.at.14.54.42.mp4

@vytick vytick added the mobile Suite Lite issues and PRs label Jun 25, 2024
@vytick vytick requested a review from a team as a code owner June 25, 2024 12:58
Comment on lines -699 to +702
title: 'Passphrase best practises',
title: 'Passphrase best practices',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not me, but that VSC extension PeKne suggested :)

@vytick vytick merged commit 1e3efb2 into develop Jun 25, 2024
15 checks passed
@vytick vytick deleted the feat/native/passphrase-loading-subtitle branch June 25, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer indication label for passphrase discovery
2 participants