feat(suite-native): no portfolio title for device connection enabled #13070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juriczech
reviewed
Jun 25, 2024
| <Text color="textSubdued" variant="hint"> | ||
| <Translation id="moduleHome.graph.title" /> | ||
| </Text> | ||
| {!isUsbDeviceConnectFeatureEnabled && ( |
There was a problem hiding this comment.
I think this won't be correct for:
- usb connection enabled and selected device is portfolio tracker
There was a problem hiding this comment.
Altough, after reading the task description, it's not clear what's correct behaviour to me. Could you please double-check with @shenkys?
There was a problem hiding this comment.
Hmm. Yah, it can be read two ways. i'll check, good catch.
There was a problem hiding this comment.
I've clarified with @shenkys and the result is: Remove that title for good.
06987de to
b2a992d
Compare
juriczech
approved these changes
Jul 1, 2024
b2a992d to
97a017f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "My Portfolio Balance" from graph
Related Issue
Resolve #12709
Screenshots: