Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): feature gate for view only setting #13068

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Jun 25, 2024

Gate View Only settings by isUsbDeviceConnectFeatureEnabled

Related Issue

Resolve #13066

Screenshots:

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-25.at.14.17.52.mp4

@vytick vytick added the mobile Suite Lite issues and PRs label Jun 25, 2024
@vytick vytick requested a review from a team as a code owner June 25, 2024 12:18
feat(suite-native): no portfolio title for device connection enabled
@vytick vytick force-pushed the fix/native/gate-view-only-settings branch from 47189d2 to 5f6b92e Compare June 25, 2024 12:37
Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but LGTM

@vytick vytick merged commit 29e7cf4 into develop Jun 25, 2024
13 checks passed
@vytick vytick deleted the fix/native/gate-view-only-settings branch June 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View-only settings page should be hidden on iOS
2 participants