Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Ledger derivation path for Solana and EVM #12627

Closed
wants to merge 4 commits into from

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented May 29, 2024

Description

  • discovery is done for Solana ledger derivation path and EVM Ledger Live and EVM Ledger Legacy derivation paths
  • if you enable debug mode, you can add those accounts, otherwise they are visible only if they have some balance

TODO:

  • it will report that not all coins have discovery done
    • that is caused by incorrect calculation of total accounts because first derivation path of ledger and trezor accounts in EVM is same so I skip it (by hack for now). If you add ledger account, it will have immediately number 2
  • details in SOL, CARDANO and EVM accounts if more acc available?
  • fw account type restriction
  • improve the weird accountUtils.ts
  • Sending to Ledger account / legacy account in send form.
  • maybe some tag in account name?

Related Issue

Resolves #8591

Screenshots:

Screenshot 2024-06-02 at 22 43 20
Screenshot 2024-06-02 at 22 43 42

All accounts
Screenshot 2024-05-29 at 9 54 20

@tomasklim tomasklim force-pushed the feat/solana-ethereum-paths branch from d87c061 to 517ef6a Compare May 29, 2024 07:48
@tomasklim tomasklim added EVM Issues related to networks based on Ethereum Virtual Machine solana labels May 29, 2024
@MiroslavProchazka
Copy link
Contributor

Please restrict the Ledger legacy discovery just for FW from v 2.6.0

@STew790
Copy link
Contributor

STew790 commented May 31, 2024

@tomasklim tomasklim force-pushed the feat/solana-ethereum-paths branch from 517ef6a to 3c6ef89 Compare June 2, 2024 20:42
@MiroslavProchazka
Copy link
Contributor

@STew790 , have you validated the derivation paths on Ledger? Do we know if we are discovering the right addresses?

@tomasklim
Copy link
Member Author

tomasklim commented Jun 3, 2024

@Hermez-cz

  1. do you agree to add account type here?
    Screenshot 2024-06-03 at 20 52 38
  • for accounts which are not default, we should show at least some tag what account type it is
  • should I add details tab to Ethereum, Solana and Cardano for non-default accounts or also for default ones?
  • how about adding some banner that the account is not "official"?
  • Ledger Ethereum n.1 account is same as Trezor n.1, thats why it is skipped, how to communicate it, to not confuse users?
    Screenshot 2024-06-03 at 20 54 47

@tomasklim
Copy link
Member Author

@tomasklim tomasklim force-pushed the feat/solana-ethereum-paths branch from 3c6ef89 to e7ba1af Compare August 4, 2024 13:59
@tomasklim tomasklim mentioned this pull request Aug 5, 2024
@tomasklim tomasklim closed this Aug 9, 2024
@tomasklim tomasklim deleted the feat/solana-ethereum-paths branch August 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EVM Issues related to networks based on Ethereum Virtual Machine solana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger Live derivation path in Suite
3 participants