-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premove #29
Premove #29
Conversation
Thanks for the PR! I haven't had time to look at it quite yet, but there are some lint errors that need to be addressed. You can run Note: If you have issues with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! I've added some comments to be addressed.
A couple additions to the review:
- The "PreMove" text is not appearing on online games.
- Premoves currently will kill an entire online game session if the pre-move is accepted but is then invalid after the opponent moves. Example: Starting as white, play e4 and premove e5. If the opponent plays e5 the game is then in a bad state. You should be able to replicate this easily in an online game against Stockfish. When quitting cli-chess after this happens, you will see exceptions in the console.
… the opponent moves.
Thanks for guide, I did fix them and commit |
premove function which #27 discussed
Closes #27