Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to polling for the kafka onramp #779

Merged
merged 7 commits into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@

* Allow using '_' as seperators in numeric literals [#645](https://github.com/tremor-rs/tremor-runtime/issues/645)
* Add support for Kafka message headers, available through the `$kafka_headers` metadata variable.
* Add the `cb` offramp for testing upstream circuit breaker behaviour [#779](https://github.com/tremor-rs/tremor-runtime/pull/779)
Licenser marked this conversation as resolved.
Show resolved Hide resolved
* Add the `kafka` onramp config `retry_failed_events` to acoid retrying failed events, and `polling_interval` to control how often kafka is polled for new messages if none were available previously [#779](https://github.com/tremor-rs/tremor-runtime/pull/779)

### Fixes

* Fix `kafka` onramp hanging with no message in the queue, leading to delayed offset commits [#779](https://github.com/tremor-rs/tremor-runtime/pull/779)
* Fail the `kafka` onramp if any of the configured topics could not be subscribed to [#779](https://github.com/tremor-rs/tremor-runtime/pull/779)

## 0.10.2

Expand Down
43 changes: 0 additions & 43 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ anyhow = "1"
async-channel = "1"
async-compat = "0.2"
async-compression = {version = "0.3", features = ["xz", "futures-bufread", "stream"]}
async-io = "1.3"
async-std = {version = "1.9.0", features = ["unstable", "attributes", "tokio03", "tokio1"]}
async-trait = "0.1"
async-tungstenite = {version = "0.13.0", features = ["async-std-runtime"]}
Expand Down Expand Up @@ -65,7 +64,6 @@ serde_derive = "1"
serde_yaml = "0.8"
simd-json = {version = "0.3", features = ["known-key"]}
simd-json-derive = "0.1.15"
smol = "1.2"
snap = "1"
surf = "=2.1.0"
tremor-common = {path = "tremor-common"}
Expand Down
2 changes: 0 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ extern crate serde_derive;
extern crate log;
#[macro_use]
extern crate lazy_static;
#[macro_use]
extern crate rental;

#[macro_use]
pub(crate) mod macros;
Expand Down
5 changes: 3 additions & 2 deletions src/offramp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ use crate::permge::PriorityMerge;
use crate::pipeline;
use crate::registry::ServantId;
use crate::sink::{
self, blackhole, debug, elastic, exit, file, handle_response, kafka, newrelic, postgres, rest,
stderr, stdout, tcp, udp, ws,
self, blackhole, cb, debug, elastic, exit, file, handle_response, kafka, newrelic, postgres,
rest, stderr, stdout, tcp, udp, ws,
};
use crate::source::Processors;
use crate::url::ports::{IN, METRICS};
Expand Down Expand Up @@ -110,6 +110,7 @@ pub fn lookup(name: &str, config: &Option<OpConfig>) -> Result<Box<dyn Offramp>>
"debug" => debug::Debug::from_config(config),
"elastic" => elastic::Elastic::from_config(config),
"exit" => exit::Exit::from_config(config),
"cb" => cb::CB::from_config(config),
"file" => file::File::from_config(config),
"kafka" => kafka::Kafka::from_config(config),
"newrelic" => newrelic::NewRelic::from_config(config),
Expand Down
1 change: 1 addition & 0 deletions src/sink.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use async_channel::Sender;
use halfbrown::HashMap;

pub(crate) mod blackhole;
pub(crate) mod cb;
pub(crate) mod debug;
pub(crate) mod elastic;
pub(crate) mod exit;
Expand Down
Loading