Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the elastic sink a linked transport. #715

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Make the elastic sink a linked transport. #715

merged 7 commits into from
Jan 28, 2021

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Jan 25, 2021 •
edited
Loading

Sending error reponses via err port, success responses via out port.

Pull request

Description

Changes the elastic sink to be a linked transport. When configured with linked: true, it will send error events down the err port and success events down the out port.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

@coveralls
Copy link
Collaborator

coveralls commented Jan 25, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 80.931% when pulling c5679b9 on elastic-linked into ff6c029 on main.

Licenser
Licenser requested changes Jan 25, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
src/sink/elastic.rs Outdated Show resolved Hide resolved
Licenser
Licenser requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :D nice work on adding the errors!

Licenser
Licenser previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 great work!

Matthias Wahl added 2 commits January 27, 2021 16:17
Make the elastic sink a linked transport.
c766167 
Sending error reponses via err port, success responses via out port.

Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Update changelog
3986f83 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Matthias Wahl added 4 commits January 28, 2021 13:46
Fix review comments and sanity/safety checks.
605ae39 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
add some test for serialization to tremor-value::Value
56197e9 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Add some more tests for to_value and Serializer
14d7aa1 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Expose 128bit tremor-value feature
fdf1e3b 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Ignore coverage on simple statements that dont make sense to be cover…
c5679b9 
…ed explicitly.

Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@Licenser Licenser self-requested a review January 28, 2021 14:03
Licenser
Licenser approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 woooh!

@mfelsche mfelsche merged commit 8bedc24 into main Jan 28, 2021
@mfelsche mfelsche deleted the elastic-linked branch January 28, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass Elastic errors as events, instead of logging them
3 participants
@mfelsche @coveralls @Licenser