Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing newline in error messages for some sources. #676

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Jan 6, 2021

Pull request

Description

If the source line with the error didnt end with a newline (e.g. last line), we missed to add one, so the callout starts on its own line. This is fixed here (with some horrible workaround for term highlighting).

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

@coveralls
Copy link
Collaborator

coveralls commented Jan 6, 2021

Coverage Status

Coverage increased (+0.006%) to 80.783% when pulling bde49ae on callout-newline into 4538891 on main.

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some tests and a CHANGELOG entry 👍

Matthias Wahl added 3 commits January 6, 2021 17:27
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@mfelsche mfelsche merged commit b1a97b3 into main Jan 6, 2021
@mfelsche mfelsche deleted the callout-newline branch January 6, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants