Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image and action for training docker image #576

Merged
merged 7 commits into from
Nov 10, 2020

Conversation

darach
Copy link
Member

@darach darach commented Nov 10, 2020

Signed-off-by: Darach Ennis darach@gmail.com

Pull request

Add a docker image and action suitable for learning tremor that derives from base image

Description

Add a docker image and action suitable for learning tremor that derives from base image

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #576 (316c5df) into main (0284cbe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files         101      101           
  Lines       13868    13868           
=======================================
  Hits        11166    11166           
  Misses       2702     2702           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0284cbe...e975db4. Read the comment docs.

.github/workflows/publish-courseware.yaml Outdated Show resolved Hide resolved
.github/workflows/publish-courseware.yaml Outdated Show resolved Hide resolved
Dockerfile.learn Outdated Show resolved Hide resolved
@darach darach force-pushed the courseware-docker-image branch 2 times, most recently from c4b2cdb to 836244f Compare November 10, 2020 15:07
anupdhml
anupdhml previously approved these changes Nov 10, 2020
Signed-off-by: Darach Ennis <darach@gmail.com>
@Licenser Licenser force-pushed the courseware-docker-image branch from 5ffb784 to 03654e0 Compare November 10, 2020 16:11
darach and others added 6 commits November 10, 2020 17:13
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
* reduce commands
* use tremor as baseline and use docker builder pattern
* ensure correct base version so courseware stays in sync

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Darach Ennis <darach@gmail.com>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser force-pushed the courseware-docker-image branch from 03654e0 to e975db4 Compare November 10, 2020 16:13
@Licenser Licenser merged commit 3d9f478 into main Nov 10, 2020
@Licenser Licenser deleted the courseware-docker-image branch November 10, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants