Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quite a few array access code #574

Merged
merged 7 commits into from
Nov 9, 2020
Merged

Remove quite a few array access code #574

merged 7 commits into from
Nov 9, 2020

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Nov 6, 2020

Pull request

Ensure we don't panic due to use of []

Description

using [] to access data can lead to rust panicing, we want to forbid this.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #574 (181e3d7) into main (cdb2bd2) will increase coverage by 0.02%.
The diff coverage is 81.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   80.49%   80.51%   +0.02%     
==========================================
  Files         101      101              
  Lines       13770    13868      +98     
==========================================
+ Hits        11084    11166      +82     
- Misses       2686     2702      +16     
Impacted Files Coverage Δ
src/preprocessor/lines.rs 90.00% <0.00%> (ø)
src/source.rs 37.40% <0.00%> (ø)
tremor-pipeline/src/op/grouper/bucket.rs 90.65% <ø> (ø)
tremor-script/src/query.rs 65.45% <ø> (ø)
tremor-script/src/script.rs 80.39% <ø> (ø)
src/registry.rs 74.00% <50.00%> (-0.83%) ⬇️
src/preprocessor.rs 80.75% <55.55%> (-0.30%) ⬇️
tremor-pipeline/src/executable_graph.rs 84.94% <62.50%> (-0.06%) ⬇️
tremor-pipeline/src/op/trickle/script.rs 72.72% <62.50%> (-1.05%) ⬇️
tremor-script/src/std_lib/stats.rs 62.60% <63.63%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb2bd2...181e3d7. Read the comment docs.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser force-pushed the check-for-brackets branch 3 times, most recently from 072afb6 to e0ad846 Compare November 9, 2020 17:05
@Licenser Licenser marked this pull request as ready for review November 9, 2020 17:29
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser merged commit 0284cbe into main Nov 9, 2020
@Licenser Licenser deleted the check-for-brackets branch November 9, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants