-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quite a few array access code #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfelsche
reviewed
Nov 6, 2020
Licenser
force-pushed
the
check-for-brackets
branch
from
November 6, 2020 15:03
d4714e6
to
8cada0e
Compare
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 80.49% 80.51% +0.02%
==========================================
Files 101 101
Lines 13770 13868 +98
==========================================
+ Hits 11084 11166 +82
- Misses 2686 2702 +16
Continue to review full report at Codecov.
|
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
check-for-brackets
branch
3 times, most recently
from
November 9, 2020 17:05
072afb6
to
e0ad846
Compare
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
check-for-brackets
branch
from
November 9, 2020 18:21
e0ad846
to
181e3d7
Compare
mfelsche
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Ensure we don't panic due to use of
[]
Description
using
[]
to access data can lead to rust panicing, we want to forbid this.Checklist