Upgrade librdkafka to 1.6.1 and prepare release 0.11.7 #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 14:54
This mitigates confluentinc/librdkafka#2933 which is fixed in 1.5.2. This issue was leading to hanging consumers when they tried to commit during a rebalance operation. Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Licenser
reviewed
Sep 28, 2021
| &self, | ||
| ) -> &mut stream_consumer::MessageStream<'static, LoggingConsumerContext, SmolRuntime> { | ||
| &mut self, | ||
| ) -> &mut stream_consumer::MessageStream<'_, LoggingConsumerContext, SmolRuntime> { |
There was a problem hiding this comment.
pls don't cry. This change is for the better!
There was a problem hiding this comment.
I know, but I'll be crying and sobbing in the corner until we finally can get rid of it, each transmute is a tear for me
There was a problem hiding this comment.
Each unsafe transmute kills a little kitten when executed.
added 3 commits
September 28, 2021 16:17
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
26fb5c0 to
70239b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Upgrade the dependency on librdkafka to 1.6.1
Related
Checklist