Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd pre-and-postprocessor. #1101

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Add zstd pre-and-postprocessor. #1101

merged 2 commits into from
Jul 2, 2021

Conversation

dak-x
Copy link
Contributor

@dak-x dak-x commented Jul 1, 2021

Signed-off-by: Daksh Chauhan dak-x@outlook.com

Pull request

Add zstd pre-and-postprocessors

Description

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@dak-x
Copy link
Contributor Author

dak-x commented Jul 1, 2021

The code required seems too straightforward. I feel I am missing some stuff. Also I should probably add some tests, but I do not know what tests.

@coveralls
Copy link
Collaborator

coveralls commented Jul 1, 2021

Coverage Status

Coverage increased (+0.01%) to 84.019% when pulling b8665a2 on dak-x:main into 83970b5 on tremor-rs:main.

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya :) awesome! thank you! only a few small things, one I commented inline, then there should be some tests for the processors and the lookup. You can find examples on how to dot hat in the preprocessors.rs there the other compression algorithms are tested too.

The https://github.com/tremor-rs/tremor-www-docs/blob/main/docs/artefacts/postprocessors.md and https://github.com/tremor-rs/tremor-www-docs/blob/main/docs/artefacts/preprocessors.md will need updating to reflect the new processor.

Otherwise 👍 great job :D

src/preprocessor.rs Show resolved Hide resolved
@mfelsche
Copy link
Member

mfelsche commented Jul 1, 2021

That was quick! 😎 🚀

@mfelsche
Copy link
Member

mfelsche commented Jul 1, 2021

We might also need to add libzstd as dependencies to our rpm, deb packages and to the docker image.

@dak-x
Copy link
Contributor Author

dak-x commented Jul 1, 2021

@mfelsche Where should I update this dependency for the build.

dak-x added 2 commits July 1, 2021 22:24
Signed-off-by: Daksh Chauhan <dak-x@outlook.com>
Signed-off-by: Daksh Chauhan <dak-x@outlook.com>
@mfelsche
Copy link
Member

mfelsche commented Jul 2, 2021

I think zstd brings zstd-sys which is bringing its own libzstd, so it is actually fine, no need to add anything :) sorry for the confusion.

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooh thank you!! 🚀

@Licenser Licenser merged commit 34bb417 into tremor-rs:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zstd pre- and postprocessors
5 participants