Add Horner's Method #575
Merged
Add Horner's Method #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
4
to
5
| With this method, it is possible to evaluate a polynomial with only n additions and n multiplications. | ||
| Also, its storage requirements are only n times the number of bits of x. |
There was a problem hiding this comment.
I think the description would highly benefit from a comparison between Horner's scheme to a regular by-definition approach; it would also give meaning to the repeated words “only” in both sentences.
There was a problem hiding this comment.
Thank you, Lazar. I've added your suggestions. I removed the repeated "only" words and tried to make the text more clear. Also, gave comparison scenarios for a specific polynomial showing that Horner's rule would use a smaller number of mathematical operations when compared to a simple by-definition approach.
lazarljubenovic
approved these changes
Dec 3, 2020
|
@MatheusBonavite, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Horner's Method into algorithms/math. Horner's method is a clever solution named after William George Horner, to evaluate polynomial functions given a certain point. I think it would be an interesting addition since it can be used in many hardware/software applications.