treehouses internet reverse refactor (fixes #2137)
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjpadilla
approved these changes
Mar 29, 2021
Comment on lines
+17
to
+22
| ip=$(echo "$info" | grep -e '"ip": "') | ||
| org=$(echo "$info" | grep -e '"org": "') | ||
| country=$(echo "$info" | grep -o '"country": "[^;]*') | ||
| city=$(echo $info | grep -o '"city": "[^;]*' | cut -d '"' -f 4) | ||
| postal=$(echo $info | grep -o '"postal": "[^;]*' | cut -d '"' -f 4) | ||
| timezone=$(echo $info | grep -o '"timezone": "[^;]*' | cut -d '"' -f 4) |
There was a problem hiding this comment.
I feel like you can trim the grep into jq but with how unreliable jq maybe sometime, it is best to leave it how it is.
modules/internet.sh
Outdated
Comment on lines
28
to
31
| echo "$ip" | ||
| echo "$org" | ||
| echo "$country, \"city\": \"$city\", \"postal\": \"$postal\"" | ||
| echo "\"timezone\": \"$timezone\"" |
There was a problem hiding this comment.
In the original, organization and timezone were at the bottom. But this is fine 👍
dogi
approved these changes
Apr 1, 2021
treehouses internet reverse reorder and keep unique values (fixes #2137)treehouses internet reverse refactor (fixes #2137)
JLKwong
added a commit
that referenced
this pull request
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.