Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create tests/message/slack.bats (fixes #2110) #2111

Merged
merged 36 commits into from
Mar 29, 2021
Merged

create tests/message/slack.bats (fixes #2110) #2111

merged 36 commits into from
Mar 29, 2021

Conversation

JLKwong
Copy link
Member

@JLKwong JLKwong commented Mar 20, 2021

No description provided.

JLKwong added 26 commits March 19, 2021 18:27
@JLKwong
add message.bats (fixes #2110)
27de39d
@JLKwong
debugging (fixes #2110)
8476d15
@JLKwong
debugging (fixes #2110)
c4a376f
@JLKwong
only clear test tokens (fixes #2110)
07f9be8
@JLKwong
only clear test tokens (fixes #2110)
e20c3fc
@JLKwong
only clear test tokens (fixes #2110)
f1d8676
@JLKwong
only clear test tokens (fixes #2110)
c1fd8ed
@JLKwong
only clear test tokens (fixes #2110)
9a92d24
@JLKwong
only clear test tokens (fixes #2110)
abc9f7e
@JLKwong
only clear test tokens (fixes #2110)
02de8b5
@JLKwong
only clear test tokens (fixes #2110)
acc1934
@JLKwong
only clear test tokens (fixes #2110)
8044720
@JLKwong
only clear test tokens (fixes #2110)
998430c
@JLKwong
only clear test tokens (fixes #2110)
411af2a
@JLKwong
only clear test tokens (fixes #2110)
6e8ba91
@JLKwong
only clear test tokens (fixes #2110)
1516a22
@JLKwong
only clear test tokens (fixes #2110)
d97292b
@JLKwong
only clear test tokens (fixes #2110)
0822c61
@JLKwong
only clear test tokens (fixes #2110)
81abf75
@JLKwong
only clear test tokens (fixes #2110)
e3a228d
@JLKwong
only clear test tokens (fixes #2110)
604a295
@JLKwong
only clear test tokens (fixes #2110)
018733f
@JLKwong
only clear test tokens (fixes #2110)
289a08f
@JLKwong
only clear test tokens (fixes #2110)
0af491e
@JLKwong
only clear test tokens (fixes #2110)
da02bfe
@JLKwong
first usable test (fixes #2110)
99b6ca2
@JLKwong JLKwong marked this pull request as ready for review March 20, 2021 03:29
@JLKwong JLKwong requested a review from rjpadilla March 20, 2021 03:30
rjpadilla
rjpadilla reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@rjpadilla rjpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks beautiful
though you haven't removed your comments.

rjpadilla
rjpadilla approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@rjpadilla rjpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good.

@dogi dogi changed the title message.bats added (fixes #2110) create tests/message.bats (fixes #2110) Mar 22, 2021
@dogi dogi changed the title create tests/message.bats (fixes #2110) create tests/message/slack.bats (fixes #2110) Mar 22, 2021
@dogi dogi merged commit e73b306 into master Mar 29, 2021
JLKwong added a commit that referenced this pull request Apr 2, 2021
@JLKwong @dogi
create tests/message/slack.bats (fixes #2110) (#2111)
beb4ef6 
Co-authored-by: dogi <dogi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogi dogi dogi approved these changes

@rjpadilla rjpadilla rjpadilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JLKwong @dogi @rjpadilla