treehouses clone detect (fixes #2067)
#2083
Conversation
modules/clone.sh
Outdated
|
|
||
| echo ; echo "A reboot is needed to re-enable write permissions to OS." | ||
| argument="$1" | ||
| path=$(fdisk -l | grep -o '^/dev/sd[a-z]' | sort -u) |
There was a problem hiding this comment.
The use of fdisk -l piped to the grep command will never output since the ^ will try to find a line beginning with /dev/; fdisk -l will begin the line with Disk.
Also fdisk -l requires sudo privileges (I think) which may lead to problems if not running as root.
Finally remember to surround the variable value with quotes. Without wrapped quotes, its going to word split.
Heres the piped commands I used for the hardrive path: path="$(lsblk -lp | awk '{print $1}' | grep -E '/dev/sd.*')"
There was a problem hiding this comment.
@dogi improved it with this line lsblk -lp | grep disk | awk '{print $1}' | grep -E '/dev/sd.
There was a problem hiding this comment.
When I test these new piped commands, I get unnecessary duplicates of the same device:
/dev/sdc /dev/sdc1 /dev/sdc2
I'll see if I can get it to only display /dev/sdc
There was a problem hiding this comment.
I modified it to look like this:
path="$(lsblk -lp | awk '{print $1}' | grep -o '/dev/sd[a-z]' | sort -u)"
On testing it only echoed:
/dev/sdc
No description provided.