Generate and check parser code on CI #83
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Linux, we re-generate the parser code and make sure it matches up with what's committed - On other platforms, we only run tests, because generation takes a very long time, and OOMs on Windows
149be59 to
37a542c
Compare
keynmol
commented
Jan 6, 2023
| @@ -10,15 +10,22 @@ jobs: | |||
| strategy: | |||
| fail-fast: true | |||
| matrix: | |||
| os: [macos-latest, ubuntu-latest, windows-2019] | |||
| os: [macos-latest, ubuntu-20.04, windows-2019] | |||
There was a problem hiding this comment.
Drop down to 20.04 due to actions/runner-images#6709
eed3si9n
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that whatever
parser.cis added to the PR is indeed generated from the grammar (because reviewing the generated code is not possible)We only do it on linux because it OOMs on Windows, and takes a very long time on MacOS (and it's not strictly necessary)