Fix parenthesized expressions in braceless if conditions
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susliko
commented
Sep 16, 2023
| @@ -26,19 +26,19 @@ object Hello { | |||
| trait Test { | |||
| // ^ keyword | |||
| // ^ type | |||
| def meth(i: Int)(implicit x: Boolean) = ??? | |||
| def meth(i: Int)(implicit x: Boolean) = ??? | |||
There was a problem hiding this comment.
I've made definitions in this trait to be of the same indentation because
trait Foo {
def meth = ???
def anonFun = ???
}is parsed with an ERROR and this causes flacking of the highlighting test
We might want to open an issue on this, but I'm reluctant to it as scalac raises a warning for this code
-- Warning: foo.scala:3:2 ------------------------------------------------------
3 | def anonFun = ???
| ^
| Line is indented too far to the left, or a `}` is missing
a9dc60f to
e8579fa
Compare
susliko
commented
Sep 18, 2023
| // https://github.com/tree-sitter/tree-sitter-scala/issues/263 and | ||
| // https://github.com/tree-sitter/tree-sitter-scala/issues/342 | ||
| // Neither do I understand why this works, nor have I found a better solution | ||
| _if_condition: $ => prec.dynamic(4, choice( |
There was a problem hiding this comment.
I'm ashamed of this
Fixes tree-sitter#263 and tree-sitter#342 `_if_condition` extracted from `if_expression` and given a magic dynamic precedence of 4
e8579fa to
5c54434
Compare
eed3si9n
reviewed
Sep 19, 2023
| @@ -404,6 +404,11 @@ class C: | |||
| else | |||
| () | |||
|
|
|||
| if (a) || b(c) then return true | |||
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263 and #342
_if_conditionextracted fromif_expressionand given a magic dynamicprecedence of 4