Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions #76

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Remove deprecated functions #76

merged 2 commits into from
Mar 29, 2022

Conversation

ngochc
Copy link
Contributor

@ngochc ngochc commented Mar 29, 2022

Remove deprecated functions including:

  • newTaskReport
  • newConfigDiff
  • RetryExecutor
  • Timestamp

@ngochc
Remove deprecated functions
7f1f5e8 
- newTaskReport
- newConfigDiff
- RetryExecutor
- Timestamp
@ngochc ngochc requested a review from vietnguyen-td March 29, 2022 07:29
@ngochc ngochc requested a review from a team as a code owner March 29, 2022 07:29
@ngochc ngochc requested a review from hieudion March 29, 2022 07:44
vietnguyen-td
vietnguyen-td approved these changes Mar 29, 2022
View reviewed changes
Copy link

@vietnguyen-td vietnguyen-td left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngochc ngochc requested a review from dmikurube March 29, 2022 08:42
dmikurube
dmikurube approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it! LGTM.

@ngochc ngochc requested a review from a team March 29, 2022 10:23
nmpennypacker
nmpennypacker approved these changes Mar 29, 2022
View reviewed changes
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@dmikurube
Copy link
Member

Let me merge this, and release 0.4.1. Thanks!

@dmikurube dmikurube merged commit 50aa50a into master Mar 29, 2022
@dmikurube dmikurube deleted the remove_deprecated_functions branch March 29, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietnguyen-td vietnguyen-td vietnguyen-td approved these changes

@nmpennypacker nmpennypacker nmpennypacker approved these changes

@dmikurube dmikurube dmikurube approved these changes

@hieudion hieudion Awaiting requested review from hieudion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngochc @dmikurube @nmpennypacker @vietnguyen-td