Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable paging for non-incremental endpoints #49

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Disable paging for non-incremental endpoints #49

merged 4 commits into from
Jan 25, 2019

Conversation

tvhung83
Copy link
Contributor

Context

  • Zendesk document doesn't clearly mention which endpoint doesn't have pagination, but they have confirmed here that ticket_fields and ticket_forms don't support it.
  • Add dedup option to non-incremental targets

@tvhung83 tvhung83 requested a review from kietdo360 January 25, 2019 06:49
@tvhung83 tvhung83 requested a review from sakama January 25, 2019 06:51
@tvhung83
Copy link
Contributor Author

@sakama could you take a look at your convenience? I can update PR desc if you need more context.

sakama
sakama approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@sakama sakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Let's merge and test.

@tvhung83 tvhung83 removed the request for review from kietdo360 January 25, 2019 10:30
@tvhung83
Copy link
Contributor Author

Thanks! Merge now.

@tvhung83 tvhung83 merged commit 1dc9cdf into master Jan 25, 2019
@tvhung83 tvhung83 deleted the disable_paging_for_non_incremental_endpoints branch January 25, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakama sakama sakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvhung83 @sakama