Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to resolve ConnectTimeoutError #27

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Attempt to resolve ConnectTimeoutError #27

merged 1 commit into from
Apr 14, 2017

Conversation

tvhung83
Copy link
Contributor

BACKGROUND

  • Every call to request method will create a new instance of httpclient instance, without closing/destroying.

CHANGELOG

  • Re-use instance of httpclient, in attempt to resolve ConnectTimeoutError when there are a lot of request invokes.

@tvhung83
Improve httpclient usage, by not creating new instance for every ca…
67ff069 
…ll, in attempt to resolve ConnectTimeoutError
@tvhung83 tvhung83 requested a review from sakama April 13, 2017 11:19
sakama
sakama approved these changes Apr 14, 2017
View reviewed changes
Copy link
Member

@sakama sakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvhung83
Copy link
Contributor Author

Thank you, @sakama -san, will merge now.

@tvhung83 tvhung83 merged commit 85a5eea into master Apr 14, 2017
@tvhung83 tvhung83 deleted the improve_httpclient_usage branch April 14, 2017 03:42
@tvhung83 tvhung83 mentioned this pull request Apr 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakama sakama sakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvhung83 @sakama