Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSP-4943] add hasValidEndingPunctuation, update tests, readme and schema_genera… #54

Merged
merged 3 commits into from
Oct 26, 2020
Merged

[CSP-4943] add hasValidEndingPunctuation, update tests, readme and schema_genera… #54

merged 3 commits into from
Oct 26, 2020

Conversation

callum-marshall
Copy link
Contributor

@callum-marshall callum-marshall commented Oct 25, 2020 •
edited
Loading

the generateInputSchema util is warning for descriptions ending in '?' or '!'

linked issue

added hasValidEndingPunctuation and updated checkForIncompleteSchemaElements

also updated tests, readme and schema_generation.md :)

@TrayProd TrayProd changed the title add hasValidEndingPunctuation, update tests, readme and schema_genera… [CSP-4943] add hasValidEndingPunctuation, update tests, readme and schema_genera… Oct 25, 2020
@callum-marshall callum-marshall linked an issue Oct 25, 2020 that may be closed by this pull request
generateInputSchema should accept descriptions ending in ? and maybe even ! #53
Closed
@callum-marshall callum-marshall marked this pull request as ready for review October 26, 2020 08:20
@callum-marshall callum-marshall requested review from jonurry, a team and domtunstill and removed request for a team October 26, 2020 08:20
domtunstill
domtunstill previously approved these changes Oct 26, 2020
View reviewed changes
Copy link

@domtunstill domtunstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

jonurry
jonurry previously approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jonurry jonurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Callum.
I just didn't think of this use case.
Might be worth adding unit tests that include ! and ? as valid punctuation to end the sentence?

@callum-marshall callum-marshall dismissed stale reviews from jonurry and domtunstill via 181ed5d October 26, 2020 09:58
jonurry
jonurry approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jonurry jonurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@callum-marshall callum-marshall merged commit 88bbb80 into master Oct 26, 2020
@akedalat akedalat deleted the callum-marshall/CSP-4943/generateinputschema-full-stop-fix branch April 14, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domtunstill domtunstill domtunstill approved these changes

@jonurry jonurry jonurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generateInputSchema should accept descriptions ending in ? and maybe even !
3 participants
@callum-marshall @jonurry @domtunstill