Resolve a failover RADIUS server hostname if need #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RADIUS client API allows to pass list of failover servers. Active failover servers are stored within internal ets table as list of IPs/ports. So if a request will fail for a primary RADIUS server - eradius will try to find active failover server based on passed list and data from the ets table. The issue is that failover servers could be passed to the RADIUS client as list of Hosts/Ports instead of IPs/Ports. This commit adds resolving of given failover servers hostnames so if list of failover RADIUS servers contains hostnames eradius client still could find an active server.
10371da to
28546de
Compare
vkatsuba
approved these changes
Sep 2, 2022
vkatsuba
reviewed
Sep 2, 2022
| IP = get_ip(Host), | ||
| find_suitable_peer([{IP, Port, Secret} | Pool]) | ||
| catch _:_ -> | ||
| % can't resolve ip by some reasons, just ignore it |
There was a problem hiding this comment.
Maybe make sense to add log here for this case
There was a problem hiding this comment.
I don't see any sense in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RADIUS client API allows to pass list of failover servers. Active
failover servers are stored within internal ets table as list of
IPs/ports. So if a request will fail for a primary RADIUS server -
eradius will try to find active failover server based on passed
list and data from the ets table.
The issue is that failover servers could be passed to the RADIUS
client as list of Hosts/Ports instead of IPs/Ports. This commit
adds resolving of given failover servers hostnames so if list
of failover RADIUS servers contains hostnames eradius client still
could find an active server.