Fix gathering of RADIUS Accounting metrics #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using ets:match_spec_run/2 to go over given attributes to
match type of RADIUS Accounting request to update a certain metric by
RADIUS Accounting type.
The issue is that we may get RADIUS attributes during sending of a RADIUS
request in two following formats:
* [{AttrId, Value}, ...]
* [#attribute{}, ....]
But only the first one could be matched in ets:match_spec_run/2. Thus if
RADIUS attributes will be given in the second format - a RADIUS Accounting
client metric will not be updated.
This commit fixes this situation.
vkatsuba
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using ets:match_spec_run/2 to go over given attributes to
match type of RADIUS Accounting request to update a certain metric by
RADIUS Accounting type.
The issue is that we may get RADIUS attributes during sending of a RADIUS
request in two following formats:
But only the first one could be matched in ets:match_spec_run/2. Thus if
RADIUS attributes will be given in the second format - a RADIUS Accounting
client metric will not be updated.
This commit fixes this situation.