Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RADIUS dictionary for APC by Schneider Electric #203

Merged
merged 1 commit into from
May 31, 2021
Merged

Adding RADIUS dictionary for APC by Schneider Electric #203

merged 1 commit into from
May 31, 2021

Conversation

metelik
Copy link

@metelik metelik commented May 28, 2021

No description provided.

@metelik metelik requested a review from a team as a code owner May 28, 2021 15:04
vkatsuba
vkatsuba suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, delete .rebar3/rebar_compiler_erl/source.dag. The .rebar3 is not a part of source.

@vkatsuba vkatsuba mentioned this pull request May 28, 2021
Closed
@metelik
Copy link
Author

metelik commented May 28, 2021

Please, delete .rebar3/rebar_compiler_erl/source.dag. The .rebar3 is not a part of source.

Done.

@metelik metelik requested a review from vkatsuba May 28, 2021 15:16
vkatsuba
vkatsuba suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash all commits into one single commit.

Adding RADIUS dictionary for APC by Schneider Electric
2ab10e3 
updatinf dictionaries and rebar_compiler.erl

Removing the .rebar3/rebar_compiler_erl/source.dag
@metelik metelik force-pushed the feature/apc_dictionary2 branch from 0d35d1c to 2ab10e3 Compare May 28, 2021 15:24
@metelik
Copy link
Author

metelik commented May 28, 2021

Please, squash all commits into one single commit.

On this branch squashing worked much better ;)

@metelik metelik requested a review from vkatsuba May 28, 2021 15:26
@vkatsuba
Copy link
Contributor

LGTM.

@vkatsuba vkatsuba requested a review from 0xAX May 28, 2021 16:09
@vkatsuba vkatsuba merged commit cf4b712 into travelping:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

@0xAX 0xAX 0xAX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metelik @vkatsuba @0xAX