-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@uppy/tus: fix onBeforeRequest type #5566
Merged
Murderlon
merged 1 commit into
transloadit:main
from
dschmidt:fix/on-before-request-type
Jan 6, 2025
Merged
@uppy/tus: fix onBeforeRequest type #5566
Murderlon
merged 1 commit into
transloadit:main
from
dschmidt:fix/on-before-request-type
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesNo diff |
No idea, why we have a promise there at all - but the type seems wrong anyhow 😁 |
Murderlon
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Murderlon
changed the title
fix(types): tus.onBeforeRequest handler may return a promise
@uppy/tus: fix onBeforeRequest type
Jan 6, 2025
Merged
github-actions bot
added a commit
that referenced
this pull request
Jan 6, 2025
| Package | Version | Package | Version | | -------------------------- | ------- | -------------------------- | ------- | | @uppy/audio | 2.1.0 | @uppy/onedrive | 4.2.0 | | @uppy/aws-s3 | 4.2.0 | @uppy/progress-bar | 4.2.0 | | @uppy/box | 3.2.0 | @uppy/provider-views | 4.3.0 | | @uppy/companion-client | 4.4.0 | @uppy/react | 4.2.0 | | @uppy/compressor | 2.2.0 | @uppy/remote-sources | 2.3.0 | | @uppy/core | 4.4.0 | @uppy/screen-capture | 4.2.0 | | @uppy/dashboard | 4.3.0 | @uppy/status-bar | 4.1.0 | | @uppy/drag-drop | 4.1.0 | @uppy/store-default | 4.2.0 | | @uppy/drop-target | 3.1.0 | @uppy/svelte | 4.2.0 | | @uppy/dropbox | 4.2.0 | @uppy/thumbnail-generator | 4.1.0 | | @uppy/facebook | 4.2.0 | @uppy/transloadit | 4.2.0 | | @uppy/file-input | 4.1.0 | @uppy/tus | 4.2.0 | | @uppy/form | 4.1.0 | @uppy/unsplash | 4.2.0 | | @uppy/golden-retriever | 4.1.0 | @uppy/url | 4.2.0 | | @uppy/google-drive | 4.3.0 | @uppy/utils | 6.1.0 | | @uppy/google-drive-picker | 0.3.0 | @uppy/vue | 2.1.0 | | @uppy/google-photos | 0.5.0 | @uppy/webcam | 4.1.0 | | @uppy/google-photos-picker | 0.3.0 | @uppy/webdav | 0.3.0 | | @uppy/image-editor | 3.3.0 | @uppy/xhr-upload | 4.3.0 | | @uppy/informer | 4.2.0 | @uppy/zoom | 3.2.0 | | @uppy/instagram | 4.2.0 | uppy | 4.11.0 | | @uppy/locales | 4.5.0 | | | - meta: build(deps): bump docker/metadata-action from 5.5.1 to 5.6.1 (dependabot[bot] / #5525) - examples,@uppy/svelte: build(deps-dev): bump @sveltejs/kit from 2.5.17 to 2.8.3 (dependabot[bot] / #5526) - meta: build(deps): bump docker/build-push-action from 6.9.0 to 6.10.0 (dependabot[bot] / #5531) - meta: build(deps): bump elliptic from 6.5.7 to 6.6.0 (dependabot[bot] / #5498) - @uppy/utils: Use .js(x) for all imports instead .ts(x) (Merlijn Vos / #5573) - @uppy/angular,@uppy/audio,@uppy/aws-s3,@uppy/box,@uppy/companion-client,@uppy/compressor,@uppy/core,@uppy/dashboard,@uppy/drag-drop,@uppy/drop-target,@uppy/dropbox,@uppy/facebook,@uppy/file-input,@uppy/form,@uppy/golden-retriever,@uppy/google-drive-picker,@uppy/google-drive,@uppy/google-photos-picker,@uppy/google-photos,@uppy/image-editor,@uppy/informer,@uppy/instagram,@uppy/locales,@uppy/onedrive,@uppy/progress-bar,@uppy/provider-views,@uppy/react,@uppy/remote-sources,@uppy/screen-capture,@uppy/status-bar,@uppy/thumbnail-generator,@uppy/transloadit,@uppy/tus,@uppy/unsplash,@uppy/url,@uppy/vue,@uppy/webcam,@uppy/webdav,@uppy/xhr-upload,@uppy/zoom: Remove "paths" from all tsconfig's (Merlijn Vos / #5572) - @uppy/tus: fix onBeforeRequest type (Dominik Schmidt / #5566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f.
uppy/packages/@uppy/tus/src/index.ts
Lines 243 to 271 in d6156bb
Sonarcloud was complaining because we returned a Promise in our onBeforeRequest handler:
owncloud/web#12052 (comment)