uppy: remove legacy bundle #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvz
approved these changes
Jan 2, 2024
IE11 is long dead, Uppy doesn't use any web API that is not already supported by every major browsers, maintaining the legacy bundle is more work than it's worth, let's get rid of it!
|
So we are doing this for 4.0 release, right? In that case, I think it’s totally worth it in 2024. |
|
Yes, this is targeted to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 is long dead, Uppy doesn't use any web API that is not already supported by every major browsers, maintaining the legacy bundle is more work than it's worth, let's get rid of it!
In particular, the issue we have is that Babel is unable to read TS source, and I'm not sure wether it's easy to fix or hard, but frankly I doubt it's worth anyone's time to figure it out.
If this lands, folks wanting to maintain compat with older browsers would need to polyfill and transpile Uppy themselves, or stay on the legacy 3.x bundle.