Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clean script #4820

Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix clean script #4820

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10b9890
fix clean script
mifi Dec 12, 2023
e228c6c
fixup! fix clean script
aduh95 Dec 12, 2023
7fe6d33
Update package.json
mifi Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"start:companion": "bash bin/companion.sh",
"start:companion:with-loadbalancer": "e2e/start-companion-with-load-balancer.mjs",
"build:bundle": "yarn node ./bin/build-bundle.mjs",
"build:clean": "rm -rf packages/*/lib packages/@uppy/*/lib packages/*/dist packages/@uppy/*/dist",
"build:clean": "git clean -e node_modules -xfd packages e2e .parcel-cache coverage",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit much to clean node_modules? Especially for every e2e run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-e is for exclude: https://git-scm.com/docs/git-clean#Documentation/git-clean.txt--eltpatterngt

"build:companion": "yarn workspace @uppy/companion build",
"build:css": "yarn node ./bin/build-css.js",
"build:svelte": "yarn workspace @uppy/svelte build",
Expand All @@ -141,7 +141,7 @@
"format": "prettier -w .",
"release": "PACKAGES=$(yarn workspaces list --json) yarn workspace @uppy-dev/release interactive",
"size": "echo 'JS Bundle mingz:' && cat ./packages/uppy/dist/uppy.min.js | gzip | wc -c && echo 'CSS Bundle mingz:' && cat ./packages/uppy/dist/uppy.min.css | gzip | wc -c",
"e2e": "yarn build && yarn e2e:skip-build",
"e2e": "build:clean && yarn build && yarn e2e:skip-build",
"e2e:skip-build": "npm-run-all --parallel watch:js:lib e2e:client start:companion:with-loadbalancer e2e:cypress",
"e2e:ci": "start-server-and-test 'npm-run-all --parallel e2e:client start:companion:with-loadbalancer' '1234|3020' e2e:headless",
"e2e:client": "yarn workspace e2e client:start",
Expand Down