Stricter linter #3095
Merged
Stricter linter #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bda966 to
ef72d5a
Compare
|
Thanks for attacking this! |
Murderlon
approved these changes
Aug 12, 2021
| @@ -81,6 +81,7 @@ module.exports = function Dashboard (props) { | |||
| onDrop={props.handleDrop} | |||
| > | |||
| <div | |||
| aria-hidden="true" | |||
There was a problem hiding this comment.
83:7 error Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events
83:7 error Static HTML elements with event handlers require a role jsx-a11y/no-static-element-interactions
Since it's the overlay, I thought the easiest thing to do was to hide it from screen readers, but maybe there's a better way?
|
Some tests are still failing though |
arturi
approved these changes
Aug 17, 2021
2214b56 to
d8009a7
Compare
Murderlon
added a commit
that referenced
this pull request
Aug 19, 2021
* 'main' of https://github.com/transloadit/uppy: Add referrer to transloadit.com link (#3116) @uppy/locales latest version is 1.22.0 🙈 Stricter linter (#3095) @uppy/aws-s3: refactor to use private fields (#3094) build: fix legacy bundle (#3112) Fix locales — point to CDN v1.31.0
Murderlon
added a commit
that referenced
this pull request
Aug 25, 2021
* main: (23 commits) Release Set node version in `workflows/cdn.yml` to 16.x Release build: add stylelint (#3124) Core: rename allowMultipleUploads to allowMultipleUploadBatches (#3115) meta: enforce `no-unused-vars` linter rule (#3118) writing-plugins: update example to use `i18nInit` (#3122) @uppy/core: reject empty string as valid value for required meta fields (#3119) Safely escape <script> injected code in companion `send-token.js` (#3101) @uppy/dashboard: fix metafield form validation (#3113) Clean up `BACKLOG.md` & add Vimeo as todo Add referrer to transloadit.com link (#3116) @uppy/locales latest version is 1.22.0 🙈 Stricter linter (#3095) @uppy/aws-s3: refactor to use private fields (#3094) build: fix legacy bundle (#3112) Fix locales — point to CDN v1.31.0 Fix typo in `docs/companion.md` Changelog for 1.31.0 and patches Strictly type uppy events (#3085) ...
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* enforce some eslint rules * enforce accessibility linter rules * harden lint rules with only 1 or 2 warnings * fix remaining rules with less than 3 warnings * fix e2e tests * fix remaining rules with less than 4 warnings * fix remaining rules with less than 6 warnings * fix `shuffleTaglines` * fix companion build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-await-in-looprule as I don't see why we would want to enforce that.Remaining rules that warn: