Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status Bar and Dashboard: add “done” after upload is complete #2653

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Status Bar and Dashboard: add “done” after upload is complete #2653

merged 4 commits into from
Nov 25, 2020

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Nov 24, 2020 •
edited
Loading

Screenshot 2020-11-24 at 16 41 11

Fixes #1510 Fixes #875

@arturi arturi requested review from goto-bus-stop and nqst November 24, 2020 19:38
nqst
nqst approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@nqst nqst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@arturi arturi merged commit d40ad5d into master Nov 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the status-bar-done branch November 25, 2020 18:09
@gaelicwinter
Copy link
Contributor

Thanks very much for this one!

@arturi arturi mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqst nqst nqst approved these changes

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Done button when upload is successfully finished Adding Dashboard 'Done' button
3 participants
@arturi @gaelicwinter @nqst