fix lint

.eslintrc.js

@@ -469,7 +469,7 @@ module.exports = {
     },
     {
       files: ['packages/@uppy/*/src/**/*.ts', 'packages/@uppy/*/src/**/*.tsx'],
-      excludedFiles: ['packages/@uppy/**/*.test.ts'],
+      excludedFiles: ['packages/@uppy/**/*.test.ts', 'packages/@uppy/core/src/mocks/*.ts'],
       rules: {
         '@typescript-eslint/explicit-function-return-type': 'error',
       },

packages/@uppy/core/src/Restricter.ts

@@ -1,7 +1,5 @@
 /* eslint-disable max-classes-per-file, class-methods-use-this */
-// @ts-expect-error untyped
 import prettierBytes from '@transloadit/prettier-bytes'
-// @ts-expect-error untyped
 import match from 'mime-match'
 import Translator from '@uppy/utils/lib/Translator'
 import type { Body, Meta, UppyFile } from '@uppy/utils/lib/UppyFile'

packages/@uppy/core/src/UIPlugin.ts

@@ -163,6 +163,7 @@ class UIPlugin<
    * This is the case with @uppy/react plugins, for example.
    */
   render(state: Record<string, unknown>): ComponentChild {
+    // eslint-disable-line @typescript-eslint/no-unused-vars
     throw new Error(
       'Extend the render method to add your plugin to a DOM element',
     )

packages/@uppy/core/src/Uppy.test.ts

@@ -2291,6 +2291,8 @@ describe('src/Core', () => {
         data: new File([sampleImage], { type: 'image/jpeg' }),
       })
 
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore accessing private field
       core[Symbol.for('uppy test: createUpload')](
         Object.keys(core.getState().files),
       )
@@ -2312,6 +2314,7 @@ describe('src/Core', () => {
           strings: {
             test: 'beep boop',
           },
+          pluralize: () => 0,
         },
       })
 

packages/@uppy/core/src/Uppy.ts

@@ -2,7 +2,6 @@
 /* global AggregateError */
 
 import Translator from '@uppy/utils/lib/Translator'
-// @ts-expect-error untyped
 import ee from 'namespace-emitter'
 import { nanoid } from 'nanoid/non-secure'
 import throttle from 'lodash/throttle.js'
@@ -327,7 +326,6 @@ export class Uppy<M extends Meta, B extends Body> {
 
     // Exposing uppy object on window for debugging and testing
     if (this.opts.debug && typeof window !== 'undefined') {
-      // @ts-expect-error string as index type is fine
       window[this.opts.id] = this
     }
 
@@ -1623,7 +1621,9 @@ export class Uppy<M extends Meta, B extends Body> {
     return undefined
   }
 
-  [Symbol.for('uppy test: getPlugins')](type: string): UnknownPlugin<M, B>[] {
+  private [Symbol.for('uppy test: getPlugins')](
+    type: string,
+  ): UnknownPlugin<M, B>[] {
     return this.#plugins[type]
   }
 
@@ -1798,9 +1798,8 @@ export class Uppy<M extends Meta, B extends Body> {
     return uploadID
   }
 
-  // @ts-expect-error same type as createUpload
-  [Symbol.for('uppy test: createUpload')](...args): string {
-    // @ts-expect-error same type as createUpload
+  private [Symbol.for('uppy test: createUpload')](...args): string {
+    // @ts-expect-error https://github.com/microsoft/TypeScript/issues/47595
     return this.#createUpload(...args)
   }
 

packages/@uppy/core/src/mocks/acquirerPlugin1.ts

@@ -1,8 +1,8 @@
 import { vi } from 'vitest' // eslint-disable-line import/no-extraneous-dependencies
 import UIPlugin from '../UIPlugin.ts'
 
-export default class TestSelector1 extends UIPlugin {
-  constructor (uppy, opts) {
+export default class TestSelector1 extends UIPlugin<any, any, any> {
+  constructor(uppy, opts) {
     super(uppy, opts)
     this.type = 'acquirer'
     this.id = 'TestSelector1'
@@ -15,7 +15,7 @@ export default class TestSelector1 extends UIPlugin {
     }
   }
 
-  run (results) {
+  run(results) {
     this.uppy.log({
       class: this.constructor.name,
       method: 'run',
@@ -25,11 +25,11 @@ export default class TestSelector1 extends UIPlugin {
     return Promise.resolve('success')
   }
 
-  update (state) {
+  update(state) {
     this.mocks.update(state)
   }
 
-  uninstall () {
+  uninstall() {
     this.mocks.uninstall()
   }
 }

packages/@uppy/core/src/mocks/acquirerPlugin2.ts

@@ -1,8 +1,8 @@
 import { vi } from 'vitest' // eslint-disable-line import/no-extraneous-dependencies
 import UIPlugin from '../UIPlugin.ts'
 
-export default class TestSelector2 extends UIPlugin {
-  constructor (uppy, opts) {
+export default class TestSelector2 extends UIPlugin<any, any, any> {
+  constructor(uppy, opts) {
     super(uppy, opts)
     this.type = 'acquirer'
     this.id = 'TestSelector2'
@@ -15,7 +15,7 @@ export default class TestSelector2 extends UIPlugin {
     }
   }
 
-  run (results) {
+  run(results) {
     this.uppy.log({
       class: this.constructor.name,
       method: 'run',
@@ -25,11 +25,11 @@ export default class TestSelector2 extends UIPlugin {
     return Promise.resolve('success')
   }
 
-  update (state) {
+  update(state) {
     this.mocks.update(state)
   }
 
-  uninstall () {
+  uninstall() {
     this.mocks.uninstall()
   }
 }

packages/@uppy/core/src/mocks/invalidPluginWithoutId.ts

@@ -1,13 +1,17 @@
 import UIPlugin from '../UIPlugin.ts'
 
-export default class InvalidPluginWithoutName extends UIPlugin {
-  constructor (uppy, opts) {
+export default class InvalidPluginWithoutName extends UIPlugin<any, any, any> {
+  public type: string
+
+  public name: string
+
+  constructor(uppy, opts) {
     super(uppy, opts)
     this.type = 'acquirer'
     this.name = this.constructor.name
   }
 
-  run (results) {
+  run(results) {
     this.uppy.log({
       class: this.constructor.name,
       method: 'run',

packages/@uppy/core/src/mocks/invalidPluginWithoutType.ts

@@ -1,13 +1,17 @@
 import UIPlugin from '../UIPlugin.ts'
 
-export default class InvalidPluginWithoutType extends UIPlugin {
-  constructor (uppy, opts) {
+export default class InvalidPluginWithoutType extends UIPlugin<any, any, any> {
+  public id: string
+
+  public name: string
+
+  constructor(uppy, opts) {
     super(uppy, opts)
     this.id = 'InvalidPluginWithoutType'
     this.name = this.constructor.name
   }
 
-  run (results) {
+  run(results) {
     this.uppy.log({
       class: this.constructor.name,
       method: 'run',