-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
12 changed files
with
282 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* eslint-disable react/react-in-jsx-scope */ | ||
| /* eslint-disable import/no-extraneous-dependencies */ | ||
| import React from 'react' | ||
| import { describe, expect, expectTypeOf, it } from 'vitest' | ||
| import { renderHook, render, act } from '@testing-library/react' | ||
| import Uppy from '@uppy/core' | ||
|
|
||
| import useUppyState from './useUppyState.ts' | ||
|
|
||
| describe('useUppyState', () => { | ||
| it('should return and update value with the correct type', () => { | ||
| const uppy = new Uppy() | ||
| const { result, rerender } = renderHook(() => | ||
| useUppyState(uppy, (state) => state.totalProgress), | ||
| ) | ||
| expectTypeOf(result.current).toEqualTypeOf<number>() | ||
| expect(result.current).toBe(0) | ||
| act(() => uppy.setState({ totalProgress: 50 })) | ||
| rerender() | ||
| expect(result.current).toBe(50) | ||
| rerender() | ||
| expect(result.current).toBe(50) | ||
| }) | ||
|
|
||
| it('does not re-render unnecessarily', () => { | ||
| const uppy = new Uppy() | ||
| let renderCount = 0 | ||
|
|
||
| const Component = React.memo((props: { uppy: Uppy<any, any> }) => { | ||
| const files = useUppyState(props.uppy, (state) => | ||
| Object.values(state.files), | ||
| ) | ||
| renderCount++ | ||
| return <div>{files.length}</div> | ||
| }) | ||
|
|
||
| const { rerender } = render(<Component uppy={uppy} />) | ||
| expect(renderCount).toBe(1) | ||
| // Re-render without updating Uppy's state | ||
| rerender(<Component uppy={uppy} />) | ||
| // It should have been memoized | ||
| expect(renderCount).toBe(1) | ||
| act(() => uppy.addFile({ name: 'file', data: new Blob() })) | ||
| expect(renderCount).toBe(2) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import type { Uppy, State } from '@uppy/core' | ||
| import type { Body, Meta } from '@uppy/utils/lib/UppyFile' | ||
| import { useMemo, useCallback } from 'react' | ||
| import { useSyncExternalStoreWithSelector } from 'use-sync-external-store/with-selector' | ||
|
|
||
| export default function useUppyState< | ||
| M extends Meta = Meta, | ||
| B extends Body = Body, | ||
| T = any, | ||
| >(uppy: Uppy<M, B>, selector: (state: State<M, B>) => T): T { | ||
| const subscribe = useMemo( | ||
| () => uppy.store.subscribe.bind(uppy.store), | ||
| [uppy.store], | ||
| ) | ||
| const getSnapshot = useCallback(() => uppy.store.getState(), [uppy.store]) | ||
|
|
||
| return useSyncExternalStoreWithSelector( | ||
| subscribe, | ||
| getSnapshot, | ||
| null, | ||
| selector, | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.