INT-B-20984 Validate SIT Departure Date

[brianmanley-caci]

Agility ticket

Summary

This is story is to validate that the SIT Entry date is before the SIT Departure date. This addresses two places in the app that were not preventing the user from entering invalid dates. 1) When the prime user creates SIT service items. 2) When the TOO updates the SIT Entry date. Now in both these situations we will return an error if the user attempts to use a SIT Entry Date that is not before the SIT Departure date.

Verification Steps for the Author

These are to be checked by the author.

• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the Gitlab build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

Prime Simulator Service Item Creation Test

1. Access the office application.
2. Login as a Prime Simulator.
3. Select an Approved move.
4. Click the Add Service Item button.
5. For Service item type choose Origin SIT
6. Choose a SIT departure date that is on or before the SIT entry Date.
7. Fill out all required fields.
8. Click the Create service item button.
9. Verify that you receive an error message: the SIT Departure Date (2025-02-10) must be after the SIT Entry Date (2025-02-10).
10. Repeat steps 5-9, but choose Destination SIT instead of Origin SIT.

TOO Update SIT Service Item Entry Date Test

1. Access the office application.
2. Login as a Prime Simulator.
3. Select an Approved move.
4. Click the Add Service Item button.
5. For Service item type choose Origin SIT
6. Fill out all required fields with valid input.
7. Click the Create service item button.
8. Log out of the application.
9. Login as a TOO.
10. Search for the Move you just added the service items on.
11. Under the Move Task Order, Accept the SIT service items.
12. Click the Edit button beside the 1st day SIT service item.
13. Enter an Entry Date that is after the departure date.
14. Enter Office remarks.
15. Click the Save button.
16. You should receive an error message: UpdateSitEntryDate failed for service item: the SIT Entry Date (2025-02-13) must be before the SIT Departure Date (2025-02-07)
17. Repeat steps 5-17 for Destination SIT.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[ryan-mchugh]

conflicts and one minor comment

[brianmanley-caci]

conflicts and one minor comment

Conflicts resolved.

[ryan-mchugh]

Local Testing
origin (also tested different dates)

still works with valid dates

destination


still works with valid dates

[ryan-mchugh]

I did notice that when the api comes back for origin SIT, I have to refresh to resubmit. Not sure that's related to your work.
Approving ✅

[ryan-mchugh]

More Local Testing

ORIGIN

DESTINATION

[brianmanley-caci]

@ryan-mchugh the merge back from int killed your approval.