Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21440 int #14739

Merged
merged 18 commits into from
Feb 7, 2025
Merged

B 21440 int #14739

merged 18 commits into from
Feb 7, 2025

Conversation

CoryKleinjanCACI
Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI commented Feb 4, 2025

B-21440

Summary

This PR updates the TIO role to show the pricing breakdown for international shuttle service items. The other items from the acceptance criteria are shared with the TOO task, and are already complete.

How to test

  1. Access the Milmove application
  2. Login as a Customer
  3. Create an international move with an HHG
  4. Approve the move as SC/TOO
  5. Login to the Prime Sim and add an IOSHUT and IDSHUT service item
  6. Login as a TOO and approve the service items
  7. Login to Prime Sim and update the shipment pickup/delivery dates, estimated weight, and actual weight
  8. Create a payment request that includes the IOSHUT and IDSHUT service items
  9. Login as TIO, find the move you created, and verify that the Market (Conus/Oconus) and shuttle type (destination/origin) are displayed on the move task order tab for the move you created
  10. Move the the payment requests tab and click the review service items button
  11. Verify that the cost breakdown (shown bu clicking 'show breakdown' for some service items) is shown for both IOSHUT and IDSHUT

Screenshots

Screenshot 2025-02-05 at 9 09 31 AM
Screenshot 2025-02-05 at 9 09 45 AM

@CoryKleinjanCACI CoryKleinjanCACI requested a review from a team as a code owner February 4, 2025 17:11
Copy link
Contributor

mergify bot commented Feb 4, 2025

⚠️ The sha of the head commit of this PR conflicts with #13768. Mergify cannot evaluate rules on this PR. ⚠️

@CoryKleinjanCACI CoryKleinjanCACI changed the base branch from main to integrationTesting February 4, 2025 17:19
@CoryKleinjanCACI CoryKleinjanCACI requested review from a team as code owners February 4, 2025 17:19
@CoryKleinjanCACI CoryKleinjanCACI self-assigned this Feb 5, 2025
@CoryKleinjanCACI CoryKleinjanCACI added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 5, 2025
@CoryKleinjanCACI CoryKleinjanCACI changed the title B 21440 int B 21440 int (review 21440 first) Feb 5, 2025
@CoryKleinjanCACI CoryKleinjanCACI changed the title B 21440 int (review 21440 first) B 21440 int (review 21439 first) Feb 5, 2025
MInthavongsay
MInthavongsay previously approved these changes Feb 6, 2025
Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Screenshot 2025-02-06 at 9 30 23 AM
Screenshot 2025-02-06 at 9 29 11 AM

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm seeing an issue with one of the playwright tests. So far, everything else has looked good.

playwright/tests/utils/testharness.js Outdated Show resolved Hide resolved
@antgmann
Copy link
Contributor

antgmann commented Feb 7, 2025

Also, it looks like there's some merge conflicts

@antgmann
Copy link
Contributor

antgmann commented Feb 7, 2025

Testing steps work! Once playwright and conflicts are fixed I'll be good to approve

antgmann
antgmann previously approved these changes Feb 7, 2025
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing, conflicts resolved!

@CoryKleinjanCACI CoryKleinjanCACI changed the title B 21440 int (review 21439 first) B 21440 int Feb 7, 2025
@r-mettler r-mettler merged commit ce32f0d into integrationTesting Feb 7, 2025
6 checks passed
@r-mettler r-mettler deleted the B-21440-INT branch February 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

4 participants