-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-22057 #14339
MAIN B-22057 #14339
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving while still in draft, will re-request myself as a reviewer if more changes are required after demo
PO accepted this morning.. good to go |
INT PR
Agility ticket
Summary
With the work done in B-21986 we changed how the estimated & (new) max incentive calculations are done for PPMs. Problem is, we had a handful of PPMs in prod that need to be retroactively addressed.
This PR added a prod migration that will change move, shipment, and PPM statuses when:
max_incentive
inppm_shipments
isNULL
This PR also adds a way for the SC to see the
Max Incentive
value stored in themax_incentive
column in theppm_shipments
tableMigration:
This will land the PPM/shipments back into the SC's queue, where they can "Submit move details" again after reviewing and the max and estimated incentives will recalculate based on the new code in
pkg/services/move_task_order/move_task_order_updater.go
How to test
max_incentive
value toNULL
NEEDS SERVICE COUNSELING
status)max_incentive
populate after saving & continuing through thatSubmit move details
as the SC