B 21464 int

[CoryKleinjanCACI]

B-21464

Summary

Updated mtoshipment query to pull SITDestinationFinalAddress in service items

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the MilMove application
2. Login as a Customer
3. Create a Move with an HHG and an NTS-Release with non california zips (this is done so that all service item types can be tested)
4. Login as a Service Counselor
5. Submit the Move details for the Move you created
6. Login as a TOO
7. Approve the shipments for the move you created
8. Login to the Prime simulator
9. Select the move you created
10. Update the HHG and NTS shipments with Pickup/Dropoff dates and weights
11. Select the "Update Destination Address" button for both the NTS and HHG, and request the destination address updated to California Zip 90210
12. Login as a TOO
13. Select to edit the HHG shipment
14. Select the option to review the destination address change
15. Approve the change
16. Select to edit the NTS shipment
17. Select the option to review the destination address change
18. Approve the change
19. Navigate to the Move Task Order page and verify the the service items have estimated prices
20. Login to the Prime simulator
21. Select the move you created
22. Select the "Update Destination Address" button for both the NTS and HHG, and request the destination address updated to Kentucky Zip 42420
23. Login as a TOO
24. Select to edit the HHG shipment
25. Select the option to review the destination address change
26. Approve the change
27. Select to edit the NTS shipment
28. Select the option to review the destination address change
29. Approve the change
30. Navigate to the Move Task Order page and verify the the service items have different estimated prices

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[ajlusk]

Original functionality appears to be intact. Delivery address are being returned by the API.

These addresses are not displayed to the TOO on the service items until the service item is approved or rejected. While the service item is pending approval only a dash is displayed even though the API is already supplying those addresses. This may be a defect but is unrelated to this PR.