Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B-21374 I-13575 fix ternary #14279

Merged
merged 1 commit into from
Nov 25, 2024
Merged

B-21374 I-13575 fix ternary #14279

merged 1 commit into from
Nov 25, 2024

Conversation

cameroncaci
Copy link
Contributor

@cameroncaci cameroncaci commented Nov 25, 2024 •
edited
Loading

B-21374

I-13575

Summary

Resolves ternary condition returning 0 on the HTML page by converting 0 as falsy to be FALSE when falsy.

How to test

  1. Turn on the UB flag
  2. Create a new customer
  3. Create a new order for PCS, HHG shipment, NO UB, NO DEPENDENTS
  4. Once you reach move review the Orders section should not have this 0

Screenshots

FROM
Pasted Graphic

TO
image

@cameroncaci cameroncaci added bug Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Nov 25, 2024
@cameroncaci cameroncaci requested a review from a team November 25, 2024 17:48
@cameroncaci cameroncaci self-assigned this Nov 25, 2024
@cameroncaci
Copy link
Contributor Author

Alex is still making the issue ticket, I sent him the necessary info

@cameroncaci cameroncaci changed the title fix ternary B-21374 I-13575 fix ternary Nov 25, 2024
traskowskycaci
traskowskycaci approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
image

@robot-mymove
Copy link

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against c62785e

danieljordan-caci
danieljordan-caci approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cameroncaci cameroncaci merged commit 3264843 into integrationTesting Nov 25, 2024
30 checks passed
@cameroncaci cameroncaci deleted the b-21374-issue-fixes-int branch November 25, 2024 18:39
@cameroncaci cameroncaci mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@traskowskycaci traskowskycaci traskowskycaci approved these changes

@deandreJones deandreJones Awaiting requested review from deandreJones deandreJones was automatically assigned from transcom/mountain-movers

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

Assignees

@cameroncaci cameroncaci

Labels
bug INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cameroncaci @robot-mymove @danieljordan-caci @traskowskycaci