Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21113 customer address language changes #14275

Merged

Conversation

brooklyn-welsh
Copy link
Contributor

Agility ticket

Summary

The following changes were made on the Customer side in order to make address related language consistent across the MilMove app:

  1. "Destination Address" -> "Delivery Address"
  2. "Pickup Location" -> "Pickup Address"
  3. "Current Address" -> "Pickup Address"
  4. "Origin Address" -> "Pickup Address"

How to test

  1. Login as a customer.
  2. Create a move and add one of every shipment, on the forms, verify that all form fields and titles use the above language, with no refrerence to "Origin" or "Destination".
  3. At the end, view the card for each shipment and verify that each title for the address fields use the above language, example screenshot below.

Screenshots

milmovelocal_3000_moves_3767f7f6-6b14-4680-ae9e-529600e60654_review (1)

@brooklyn-welsh brooklyn-welsh added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Nov 22, 2024
@brooklyn-welsh brooklyn-welsh changed the base branch from main to integrationTesting November 22, 2024 19:27
@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review November 25, 2024 19:47
Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesHawks224 JamesHawks224 self-requested a review November 25, 2024 20:56
Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: lgtm

@brooklyn-welsh brooklyn-welsh merged commit 7cdcee8 into integrationTesting Nov 26, 2024
30 checks passed
@brooklyn-welsh brooklyn-welsh deleted the INT-B-21113-Customer-Address-Language branch November 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants