Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21414 - TOO update for international crate approval requests #14274

Merged

Conversation

taeJungCaci
Copy link
Contributor

@taeJungCaci taeJungCaci commented Nov 22, 2024

B-21414

Summary

This adds missing details to International Crating/Uncrating service items that has been requested by the Prime in TOO Move task order page and makes sure it can be approved/denied by the TOO.

  • Added to show 'Reason', 'Market', and 'External crate' in the international cratings service item detail.
  • Added to show 'Reason' and 'Market' in the international uncratings service item detail.
  • Added - Standalone to the International Crating title if standaloneCrate is true.
  • Added logic to model_to_payload to show correct market depending on the address.isOconus

How to test

  1. Follow the steps in this PR to create international crating/uncrating service items.
  2. As a TOO -> go to the move -> move task order tab -> scroll down and you should see them under requested service items table.
  3. Verify that these details are showing for both service items.

International Crating:

Description: 
Item size: 
Crate size: 
External crate (IT WILL SHOW ONLY IF YOU CHECKED TRUE): 
Market: 
Reason: 

International Uncrating:

Description: 
Item size: 
Crate size: 
Market: 
Reason: 
  1. If you selected Standalone then it will show in the title of the service item.
  2. Click "Approve" or "Reject" to test both scenarios.
  3. Verify it works.

Screenshots

image
image
image
image

@taeJungCaci taeJungCaci added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Nov 22, 2024
@taeJungCaci taeJungCaci marked this pull request as ready for review November 22, 2024 17:14
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽
the playwright tests are a nice touch

Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: looks good, did have a comment.

Copy link
Contributor

@brooklyn-welsh brooklyn-welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taeJungCaci taeJungCaci merged commit 8a06cd1 into integrationTesting Nov 25, 2024
30 checks passed
@taeJungCaci taeJungCaci deleted the INT-B-21414-TOO-international-crate-request branch November 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

6 participants