Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21675: Destination GBLOC Incorrect #14225

Merged
merged 17 commits into from
Nov 26, 2024
Merged

Conversation

WeatherfordAaron
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron commented Nov 19, 2024

Agility Ticket B-21675

Notes before you test

  • It may help to use postal codes that fall in separate GBLOCs for Duty Locations (origin and destination) and Shipments (origin/pickup and destination) for their respective Address fields. To get the GBLOC for a postal code, you can use the following SQL query (replace the '?' with the postal code you want the GBLOC for:
SELECT gbloc FROM postal_code_to_gblocs pctg
WHERE postal_code = ?
  • The business logic should be as follows:
    • When a move has been created, before a shipment has been added:
      • Destination ZIP and GBLOC should reflect the Home of Record if they are a Retiree or Separatee. Destination ZIP and GBLOC should reflect the Destination Duty Location if they are a Service Member.
    • When at least one HHG or PPM shipment has been added to a move:
      • Destination ZIP and GBLOC should reflect the Destination Address of the first shipment on the move.

Steps I took to manually test

Retiree, Separatee

  1. As a Retiree and/or Separatee, create a move (DO NOT ADD A SHIPMENT YET).
  2. As a SC Office User, search for the move.
  • You should be able to observe that the Destination Postal Code and Destination GBLOC values reflect the HOR (Home of Record).
  1. As the Retiree/Separatee User or the SC Office User add a HHG or PPM shipment with Destination Address included.
  2. As a SC Office User, search for the move.
  • You should be able to observe that the Destination Postal Code and Destination GBLOC values reflect the Destination Address of the shipment.

Military Service Member

  1. As a Service Member (Army, Air Force, Space Force, etc.), create a move (DO NOT ADD A SHIPMENT YET).
  2. As a SC Office User, search for the move.
  • You should be able to observe that the Destination Postal Code and Destination GBLOC values reflect the Destination Duty Location.
  1. As the Service Member User or the SC Office User add a HHG or PPM shipment with Destination Address included.
  2. As a SC Office User, search for the move.
  • You should be able to observe that the Destination Postal Code and Destination GBLOC values reflect the Destination Address of the shipment.

Also

  • Make sure that it works with multiple moves
  • Make sure that it works with a move that has multiple shipments (include a mix of HHG, PPM, BOAT, or MOBILE HOME). The destination postal code and gbloc should reflect the first shipment from the shipments per move which has not been deleted, rejected, or cancelled.
  • Make sure that it works even if you delete at least one of the shipments from a move (even down to where there are 0 shipments again for the move
  • Make sure that you are able to see the destinationGBLOC and destinationPostalCode fields as part of the move information as Prime user when you view a Move (you will only see these fields as part of the object from Developer Tools or POSTMAN (see screenshot below)
    Screenshot 2024-11-22 at 9 34 54 AM

@WeatherfordAaron WeatherfordAaron self-assigned this Nov 19, 2024
@robot-mymove

This comment was marked as resolved.

@WeatherfordAaron WeatherfordAaron changed the title corrected system that shows destination zip and gbloc in move search … B-21675: Destination GBLOC Incorrect Nov 21, 2024
@WeatherfordAaron WeatherfordAaron added INTEGRATION Slated for Integration Testing ByteSize M&Ms Team ByteSized M&Ms labels Nov 21, 2024
@WeatherfordAaron WeatherfordAaron marked this pull request as ready for review November 21, 2024 13:01
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the newest changes fixed my issue with the NTS shipment, and all other shipments were tested and working. ✅

Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: lgtm

@WeatherfordAaron WeatherfordAaron merged commit 68778aa into integrationTesting Nov 26, 2024
30 checks passed
@WeatherfordAaron WeatherfordAaron deleted the INT-B-21675 branch November 26, 2024 19:13
@WeatherfordAaron WeatherfordAaron restored the INT-B-21675 branch November 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants