B 21455 main #14208
Merged
B 21455 main #14208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
MInthavongsay
approved these changes
Nov 26, 2024
antgmann
requested changes
Dec 2, 2024
Are there changes in integration that this is dependent on? The test doesn't look like it was failing in integration |
We've been investigating, we're not sure of the cause yet. It does pass in int. The submit move details button is greyed out when the client test is trying to click it, so not sure what the root cause is yet |
antgmann
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Client test is now passing with latest changes, which are being pulled into int in #14322 (review)
Looks good for a merge once the above is in INT and main is unlocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21455
INT Review
INT Review #2
INT Review #3
Summary
This change update the service counselor and TOO roles to be able update ppm shipments that have a estimated incentive of zero. An estimated incentive of zero can, currently, only be achieved when a customer pushes a PPM when DTOD is down.
The Service Counselor role updates the ppms when they select the 'Submit move details' button.
The TOO updates the ppms when the attempt to approve either the move or an individual shipment.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Service Counselor:
##THE ABILITY FOR TOO TO APPROVE PPMS IS CURRENTLY BROKEN IN INTEGRATION DUE TO ANOTHER TASK
TOO:
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots